Conversation
kohsuke
force-pushed
the
token-error-check
branch
from
aee6e01 to
83335e0
Compare
This comment has been minimized.
This comment has been minimized.
Tell apart a bad value vs no value. Also, use the ensure method to avoid duplicating errors in multiple places. Seeing incorrect value in LAUNCHABLE_TOKEN previously was a silently recovered error, but I think this behavior is harmful. If the value is incorrectly set, we need to call an attention to that fact so that we can guide users to fix it.
kohsuke
force-pushed
the
token-error-check
branch
from
83335e0 to
76bfa3b
Compare
ono-max
approved these changes
Nov 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tell apart a bad value vs no value. Also, use the ensure method to avoid duplicating errors in multiple places.