Skip to content

[csm] ignore testng-results.xml #1254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Konboi merged 2 commits into from
Mar 12, 2026
Merged

[csm] ignore testng-results.xml #1254

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6b5b413
[csm] ignore testng-results.xml
Konboi Mar 11, 2026
e08061e
fix test
Konboi Mar 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions launchable/test_runners/maven.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,11 +161,13 @@ def format_same_bin(s: str) -> List[Dict[str, str]]:
def record_tests(client, reports):
client.path_builder = junit5_nested_class_path_builder(client.path_builder)

# Override report method to filter out failsafe-summary.xml
# Override report method to filter out non-JUnit report files
original_report = client.report

IGNORED_FILES = {'failsafe-summary.xml', 'testng-results.xml'}

def report_with_filter(junit_report_file: str):
if not junit_report_file.endswith('failsafe-summary.xml'):
if not any(junit_report_file.endswith(f) for f in IGNORED_FILES):
original_report(junit_report_file)

client.report = report_with_filter
Expand Down
27 changes: 13 additions & 14 deletions tests/commands/compare/test_subsets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,17 +201,16 @@ def test_subsets_subset_ids(self):
mix_stderr=False)

self.assert_success(result)
expect = """PTS subset change summary:
────────────────────────────────
-> 3 tests analyzed | 1 ↑ promoted | 1 ↓ demoted
-> Code files affected: bbb.py, ccc.py, ddd.py
────────────────────────────────

Δ Rank Subset Rank Test Name Reason Density
-------- ------------- ----------- -------------------- ---------
NEW 1 file=ddd.py Changed file: ddd.py 0.9
↑1 2 file=ccc.py Changed file: ccc.py 0.7
↓1 3 file=bbb.py Changed file: bbb.py 0.5
DELETED - file=aaa.py
"""
self.assertEqual(result.stdout, expect)
output = result.stdout
Copy link
Contributor Author

@Konboi Konboi Mar 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: not related this change. only for fixing test

self.assertIn("3 tests analyzed | 1 ↑ promoted | 1 ↓ demoted", output)
self.assertIn("Code files affected: bbb.py, ccc.py, ddd.py", output)
self.assertIn("Δ Rank", output)
self.assertIn("Density", output)
for expected_row in [
("NEW", "1", "file=ddd.py", "Changed file: ddd.py", "0.9"),
("↑1", "2", "file=ccc.py", "Changed file: ccc.py", "0.7"),
("↓1", "3", "file=bbb.py", "Changed file: bbb.py", "0.5"),
("DELETED", "-", "file=aaa.py"),
]:
for cell in expected_row:
self.assertIn(cell, output)
Loading