Skip to content

Include polyfills in jasmine-requirejs.html; include original (full) stack trace in onError output#80

Closed
raffishquartan wants to merge 2 commits intocloudchen:masterfrom
raffishquartan:master
Closed

Include polyfills in jasmine-requirejs.html; include original (full) stack trace in onError output#80
raffishquartan wants to merge 2 commits intocloudchen:masterfrom
raffishquartan:master

Conversation

@raffishquartan
Copy link
Copy Markdown

This PR is for two minor issues I had using this template with grunt-contrib-jasmine. Some simple one line changes:

  • The template now loads polyfills as part of its require (e.g. es5-shim)
  • The error output did not include the full stack trace

Thanks!

@lukeapage lukeapage mentioned this pull request Apr 10, 2015
@purtuga
Copy link
Copy Markdown

purtuga commented Apr 11, 2015

+1 for this. Spent 2h chasing this issues last week.

@andrewshawcare
Copy link
Copy Markdown

+1

1 similar comment
@tessat
Copy link
Copy Markdown

tessat commented Jul 13, 2015

+1

@killtheliterate
Copy link
Copy Markdown

Heh, +1 didn't look here before making #85

@talon
Copy link
Copy Markdown

talon commented Sep 4, 2015

This PR adds the polyfills after the vendors. I'd argue in favor of #85 as it adds polyfills before any other JS, which is preferable.

@raffishquartan
Copy link
Copy Markdown
Author

Closing as part of GH tidy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants