Skip to content

fix: reject unsupported URLs before Gmail fallthrough in Google Gatekeeper #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Ashutosh0x wants to merge 1 commit into from
+9 −0
Closed

fix: reject unsupported URLs before Gmail fallthrough in Google Gatekeeper #72

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions packages/gatekeeper-google/src/google.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -927,6 +927,15 @@ export class GatekeeperUserImpl extends WorkerEntrypoint<Env, GatekeeperUserImpl
};
}

// Reject URLs that don't belong to Gmail before falling through to the default.
// Without this check, any URL that doesn't match Docs/Sheets/Calendar/BigQuery
// silently receives a Gmail capability, which weakens the resource-URL boundary.
if (parsed.hostname !== "mail.google.com") {
throw new Error(
`Unsupported Google resource URL: ${parsed.hostname}${parsed.pathname}. ` +
"Supported resources are Google Docs, Sheets, Calendar, BigQuery, and Gmail.");
}

// Default: Gmail
let props: GmailGatekeeperImplProps = {...this.ctx.props};

Expand Down
Loading