Open
Conversation
Author
|
perhaps experimental isn't the way to go for this particular project. I added an issue to the rollup plugin that I found with injecting env here egoist/rollup-plugin-esbuild#314 |
Contributor
|
Thanks for proposing this, couple of questions
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just a proposal, no worries if you don't think it's suitable for this project :)
Esbuild runs faster, simplifies the configuration a bit and wouldn't compile the project until (#8) was fixed. The node resolve plugin didn't seem to detect this issue.
npm run test
before
npm run test 3.26s user 0.68s system 125% cpu 3.140 totalafter (using esbuild)
npm run test 2.20s user 0.67s system 107% cpu 2.669 totalnpm run build
before
npm run build 3.21s user 0.56s system 173% cpu 2.174 totalafter
npm run build 1.48s user 0.34s system 213% cpu 0.855 total(using minify option instead of terser)
npm run build 0.44s user 0.10s system 103% cpu 0.521 totalcreated dist/index.mjs in 72ms