fix(button): Update button styles to align with Figma#53
Open
CiscoFran10 wants to merge 1 commit intocloudflare:mainfrom
Open
fix(button): Update button styles to align with Figma#53CiscoFran10 wants to merge 1 commit intocloudflare:mainfrom
CiscoFran10 wants to merge 1 commit intocloudflare:mainfrom
Conversation
- Use not-disabled and data-pressed for hover/focus/pressed states - Focus ring: ring-2 ring-kumo-brand (was ring-1 ring-kumo-ring) - Add compactSize icon sizing for SVG children - Add data-pressed extraction in component-registry utils - Regenerate component registry (Button variants and colors)
CiscoFran10
commented
Feb 9, 2026
| outline: { | ||
| classes: "bg-kumo-base text-kumo-default ring ring-kumo-line", | ||
| classes: | ||
| "bg-kumo-base text-kumo-default ring ring-kumo-line not-disabled:[:hover,[data-pressed]]:bg-kumo-control data-[state=open]:bg-kumo-control", |
Author
There was a problem hiding this comment.
In light mode, the kumo-control and kumo-base colors are identical, which makes the hover state visually indistinguishable. This likely needs an update to the light-mode Figma styles. Waiting for maintainer guidance before proceeding.
CiscoFran10
commented
Feb 9, 2026
| return cn( | ||
| // Base styles | ||
| "group flex w-max shrink-0 items-center font-medium select-none", | ||
| "group flex w-max shrink-0 items-center font-medium select-none [&_svg]:shrink-0 [&_svg]:-mx-0.5", |
Author
There was a problem hiding this comment.
[&_svg]:-mx-0.5
Minor optical alignment adjustment for SVG icons next to text.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the Button component to use unified state selectors (
not-disabled,data-pressed), updates the focus ring, and extends the component registry to supportdata-pressedextraction.Changes
focus-visible:ring-1 ring-kumo-ring→focus-visible:ring-2 ring-kumo-brand.[&_svg:not([class*='size-'])]:size-*for xs/sm/base/lg.extractStateClasses()now parsesdata-[pressed]:and populatesstateClassesfor registry output.Closes: #35