Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wanted to try to update this crate to a newer version of nom, but I realized that the raised msrvs of a lot of the dependencies of this crate made it fail to build/test.
This PR raises upgrades the toolchain to 1.63.0, which is what I believe the csv dependency now requires, which is pulled in for benchmarking via criterion. Ignoring dev-dependencies, the msrv would still need to be raised to at least 1.57.0 due to chrono.
I've also fixed the clippy issues that I saw in the saffron crate, but there may be more in the other crates. I can put that in a different PR if that's cleaner.
Also, I couldn't figure out how the CI is supposed to function, it tries to run commands at the repository root but there isn't a package there? Am I missing a workspace cargo config?