-
Notifications
You must be signed in to change notification settings - Fork 280
Add standalone self-host output and align init production scripts #178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sankalpmukim
wants to merge
13
commits into
cloudflare:main
Choose a base branch
from
sankalpmukim:feat/selfhost-standalone-build-start
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
17a416e
feat: add standalone self-host output for vinext build
09c9a2c
Merge main into feat/selfhost-standalone-build-start, resolve conflicts
james-elicx b8c22d4
fmt
james-elicx d9d676b
Address bonk review: fix duplicate PHASE constant, complete lazy-chun…
james-elicx c6eba51
Address bonk nits: document regex patterns, move PHASE re-exports to …
james-elicx 4f0a549
refactor(standalone): use Vite bundle graph for server externals inst…
james-elicx 8dbc469
fix(standalone): copy vinext runtime deps, add node_modules filter to…
james-elicx 15e8254
fix(standalone): address round-6 bonk nits — explicit root, manifest …
james-elicx 2f8d0e8
fix(standalone): address round 7 bonk review comments
james-elicx 242cc84
fix(standalone): address round 8 bonk review comments
james-elicx ab6e2a4
Merge remote-tracking branch 'origin/main' into feat/selfhost-standal…
james-elicx 5bed771
interface -> type
james-elicx 4656869
fix(standalone): address round 9 bonk review comments
james-elicx File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider adding a note that standalone mode uses
HOST(notHOSTNAME) for the bind address. Users migrating from Next.js standalone may haveHOSTNAMEconfigured in their deployment environments, and the behavioral difference would be confusing without documentation.Something like: