Cache package dependency collection results to avoid redundant filesystem walks by dario-piotrowicz · Pull Request #14672 · cloudflare/workers-sdk

dario-piotrowicz · 2026-07-13T10:58:02Z

collectPackageDependencies now accepts an optional cacheDir parameter. When provided, collected results are persisted to disk and reused on subsequent calls as long as neither package.json nor the project's lockfile have been modified. This speeds up repeated deploys when dependencies haven't changed.

Followup for #14591

Tests
- Tests included/updated
- Automated tests not possible - manual testing has been completed as follows:
- Additional testing not necessary because:
Public documentation
- Cloudflare docs PR(s):
- Documentation not necessary because: transparent DX improvement

A picture of a cute animal (not mandatory, but encouraged)

changeset-bot · 2026-07-13T10:58:09Z

🦋 Changeset detected

Latest commit: aab6245

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@cloudflare/deploy-helpers	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

ask-bonk · 2026-07-13T10:58:37Z

UnknownError: ProviderInitError

github run

ask-bonk · 2026-07-13T10:58:39Z

@dario-piotrowicz Bonk workflow failed. Check the logs for details.

View workflow run · To retry, trigger Bonk again.

github-actions · 2026-07-13T11:00:59Z

✅ All changesets look good

pkg-pr-new · 2026-07-13T11:01:16Z

@cloudflare/autoconfig

npm i https://pkg.pr.new/@cloudflare/autoconfig@14672

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@14672

@cloudflare/deploy-helpers

npm i https://pkg.pr.new/@cloudflare/deploy-helpers@14672

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@14672

miniflare

npm i https://pkg.pr.new/miniflare@14672

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@14672

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@14672

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@14672

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@14672

@cloudflare/workers-auth

npm i https://pkg.pr.new/@cloudflare/workers-auth@14672

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@14672

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@14672

wrangler

npm i https://pkg.pr.new/wrangler@14672

commit: aab6245

workers-devprod · 2026-07-13T16:30:55Z

Codeowners approval required for this PR:

@cloudflare/wrangler

Show detailed file reviewers

.changeset/cache-package-dependencies.md: [@cloudflare/wrangler]
packages/deploy-helpers/package.json: [@cloudflare/wrangler]
packages/deploy-helpers/src/deploy/deploy.ts: [@cloudflare/wrangler]
packages/deploy-helpers/src/deploy/helpers/package-dependencies.ts: [@cloudflare/wrangler]
packages/deploy-helpers/src/deploy/versions-upload.ts: [@cloudflare/wrangler]
packages/deploy-helpers/src/shared/types.ts: [@cloudflare/wrangler]
packages/deploy-helpers/tests/package-dependencies.test.ts: [@cloudflare/wrangler]
packages/wrangler/src/deployment-bundle/merge-config-args.ts: [@cloudflare/wrangler]
pnpm-lock.yaml: [@cloudflare/wrangler]

…stem walks

NuroDev · 2026-07-14T13:08:21Z

+	for (const name of KNOWN_LOCKFILES) {
+		const filePath = find.file(name, { cwd: projectPath });
+		if (filePath) {
+			const content = await readFile(filePath);


Is it worth wrapping this in a try / catch so we can safely return null with a console warning instead?

NuroDev · 2026-07-14T13:30:41Z

 		return result.length > 0 ? result : undefined;
 	} catch (error) {
-		logger.debug(
+		logger?.debug(


Why is logger now nullish? I assumed it would be a singleton, no?

NuroDev · 2026-07-14T13:31:58Z

 		"@types/node": "catalog:default",
 		"concurrently": "^8.2.2",
 		"devtools-protocol": "^0.0.1182435",
+		"empathic": "^2.0.0",


Is this dependency really needed? Can we not achieve the same functionality as empathic/find with regular Node.js tools?

NuroDev · 2026-07-14T13:35:51Z

+			const cwd = process.cwd();
+			const cacheDir = path.join(cwd, ".cache");


Would it not be better to use the temp directory helper for this?

NuroDev · 2026-07-14T13:38:34Z

+			const second = await collectPackageDependencies(cwd, { cacheDir });
+			expect(second).toEqual(first);


Would it not be better to use mocks or something similar to check to make sure the cache actually gets hit?

dario-piotrowicz · 2026-07-16T21:23:36Z

Closing in favor of #14703

workers-devprod added this to workers-sdk Jul 13, 2026

github-project-automation Bot moved this to Untriaged in workers-sdk Jul 13, 2026

This comment was marked as resolved.

Sign in to view

dario-piotrowicz force-pushed the dario/cache-pkg-deps branch 2 times, most recently from a212e68 to 809a696 Compare July 13, 2026 16:11

dario-piotrowicz marked this pull request as ready for review July 13, 2026 16:30

dario-piotrowicz requested a review from workers-devprod as a code owner July 13, 2026 16:30

workers-devprod requested review from a team and NuroDev and removed request for a team July 13, 2026 16:30

This comment was marked as resolved.

Sign in to view

dario-piotrowicz force-pushed the dario/cache-pkg-deps branch from 809a696 to e55a1ea Compare July 13, 2026 16:48

Cache package dependency collection results to avoid redundant filesy…

aab6245

…stem walks

dario-piotrowicz force-pushed the dario/cache-pkg-deps branch from e55a1ea to aab6245 Compare July 14, 2026 10:49

dario-piotrowicz marked this pull request as draft July 14, 2026 12:48

NuroDev reviewed Jul 14, 2026

View reviewed changes

dario-piotrowicz closed this Jul 16, 2026

github-project-automation Bot moved this from Untriaged to Done in workers-sdk Jul 16, 2026

		const cwd = process.cwd();
		const cacheDir = path.join(cwd, ".cache");

		const second = await collectPackageDependencies(cwd, { cacheDir });
		expect(second).toEqual(first);

Uh oh!

Conversation

dario-piotrowicz commented Jul 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot Bot commented Jul 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

ask-bonk Bot commented Jul 13, 2026

Uh oh!

ask-bonk Bot commented Jul 13, 2026

Uh oh!

github-actions Bot commented Jul 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pkg-pr-new Bot commented Jul 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

workers-devprod commented Jul 13, 2026

Uh oh!

This comment was marked as resolved.

Uh oh!

NuroDev Jul 14, 2026

Choose a reason for hiding this comment

Uh oh!

NuroDev Jul 14, 2026

Choose a reason for hiding this comment

Uh oh!

NuroDev Jul 14, 2026

Choose a reason for hiding this comment

Uh oh!

NuroDev Jul 14, 2026

Choose a reason for hiding this comment

Uh oh!

NuroDev Jul 14, 2026

Choose a reason for hiding this comment

Uh oh!

dario-piotrowicz commented Jul 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

dario-piotrowicz commented Jul 13, 2026 •

edited

Loading

changeset-bot Bot commented Jul 13, 2026 •

edited

Loading

github-actions Bot commented Jul 13, 2026 •

edited

Loading

pkg-pr-new Bot commented Jul 13, 2026 •

edited

Loading