Skip to content

Various miniflare v5 changes#14765

Open
emily-shen wants to merge 7 commits into
miniflare-v5from
miniflare-v5-deletions
Open

Various miniflare v5 changes#14765
emily-shen wants to merge 7 commits into
miniflare-v5from
miniflare-v5-deletions

Conversation

@emily-shen

@emily-shen emily-shen commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Making any config-related changes that aren't related to the new config format, before implementing support for the new config format.

Review by commit, but generally:

  1. unsafeStickyBlobs - used only for vitest isolated storage, so its just orphaned now
  2. wrapped bindings - all wrapped bindings were moved into miniflare (out of wrangler) a while ago, so the public wrapped bindings API are no longer needed. internally miniflare still uses 'wrapped bindings' in various places.
  3. structured logs by default - this is used by vite and wrangler already
  4. drop httpsKeyPath/httpsCertPath - a bit redundant when the client can just read and pass it into httpsKey/httpsCert
  5. drop fetchMock - no longer used in vitest-pool-workers, outboundService provides similar functionality.
  6. drop cacheWarnUsage (just printed a warning, but never actually wired in by wrangler or vite, probably too noisy) and rename cache plugin in cacheAPI to disambiguate from Workers cache.
  7. remove resource-specific persistence config

  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because: should just pass existing tests
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: miniflare v5 is wip

A picture of a cute animal (not mandatory, but encouraged)

@changeset-bot

changeset-bot Bot commented Jul 20, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 03c35f3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
miniflare Major
@cloudflare/vitest-pool-workers Patch
@cloudflare/deploy-helpers Patch
@cloudflare/pages-shared Patch
@cloudflare/runtime-types Patch
@cloudflare/vite-plugin Patch
wrangler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions

github-actions Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

✅ All changesets look good

@pkg-pr-new

pkg-pr-new Bot commented Jul 20, 2026

Copy link
Copy Markdown
@cloudflare/autoconfig

npm i https://pkg.pr.new/@cloudflare/autoconfig@14765

@cloudflare/config

npm i https://pkg.pr.new/@cloudflare/config@14765

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@14765

@cloudflare/deploy-helpers

npm i https://pkg.pr.new/@cloudflare/deploy-helpers@14765

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@14765

miniflare

npm i https://pkg.pr.new/miniflare@14765

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@14765

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@14765

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@14765

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@14765

@cloudflare/workers-auth

npm i https://pkg.pr.new/@cloudflare/workers-auth@14765

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@14765

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@14765

wrangler

npm i https://pkg.pr.new/wrangler@14765

commit: ce29325

@ask-bonk

ask-bonk Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Both wrangler and vite provide handleStructuredLogs and previously relied on structuredWorkerdLogs defaulting to true when a handler is set. Now that structured logging is always on, their handlers keep working. Consumers that previously did NOT provide a handler will now get structured-log-parsed console output instead of raw stdout — which is the documented behavior change.

My review is complete. All six changes are internally consistent: removed features have their call sites, tests, error codes, constants, and worker bindings cleanly removed; external consumers (wrangler ProxyController → cacheAPI, httpsKey/httpsCert via validateHttpsOptions) are updated; the unsafeStickyBlobs removal is safe since isolated storage was already dropped; and the changesets accurately document the breaking changes with a major miniflare bump. I found no logic bugs, backward-compat violations for the target (miniflare-v5), or incorrect API behavior.

LGTM

github run

@emily-shen
emily-shen force-pushed the miniflare-v5-deletions branch from 6adf14a to f7fa585 Compare July 20, 2026 14:46
@emily-shen
emily-shen force-pushed the miniflare-v5-deletions branch from 03c35f3 to ce29325 Compare July 20, 2026 19:31
@emily-shen emily-shen added the ci:run-remote-tests Run remote/E2E tests that require Cloudflare API credentials label Jul 20, 2026
@emily-shen
emily-shen marked this pull request as ready for review July 20, 2026 20:15

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:run-remote-tests Run remote/E2E tests that require Cloudflare API credentials

Projects

Status: Untriaged

Development

Successfully merging this pull request may close these issues.

2 participants