Rename PERCENTAGE to PERCENT in AdjustmentUnit enum and update related comments#583
Merged
ImMin5 merged 1 commit intocloudforet-io:masterfrom May 22, 2025
Merged
Rename PERCENTAGE to PERCENT in AdjustmentUnit enum and update related comments#583ImMin5 merged 1 commit intocloudforet-io:masterfrom
ImMin5 merged 1 commit intocloudforet-io:masterfrom
Conversation
…related comments Signed-off-by: ImMin5 <mino@megazone.com>
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the AdjustmentUnit enum by renaming the constant from PERCENTAGE to PERCENT and updates the related comment examples accordingly.
- Renamed enum constant PERCENTAGE to PERCENT.
- Updated JSON comment examples in CreateReportAdjustmentRequest and UpdateReportAdjustmentRequest to reflect the new naming.
- Added clarifying comments regarding currency sync in CreateReportAdjustmentRequest.
Comments suppressed due to low confidence (1)
proto/spaceone/api/cost_analysis/v1/report_adjustment.proto:61
- Renaming the enum constant to PERCENT appears consistent with the updated documentation examples; please ensure that all references across the codebase and documentation fully reflect this change.
PERCENT = 2;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…related comments
Category
Description
Known issue