Update cost_report.proto to reorder fields and add updated_at for tracking#585
Merged
ImMin5 merged 1 commit intocloudforet-io:masterfrom May 26, 2025
Merged
Update cost_report.proto to reorder fields and add updated_at for tracking#585ImMin5 merged 1 commit intocloudforet-io:masterfrom
ImMin5 merged 1 commit intocloudforet-io:masterfrom
Conversation
…or tracking Signed-off-by: ImMin5 <mino@megazone.com>
There was a problem hiding this comment.
Pull Request Overview
This PR reorders fields in the CostReportInfo message and adds an updated_at field to track modifications.
- Reorders project_id, workspace_id, and domain_id fields, while introducing a new service_account_id field.
- Adds an updated_at field to track changes.
Comments suppressed due to low confidence (1)
proto/spaceone/api/cost_analysis/v1/cost_report.proto:110
- Reordering fields and assigning new tag numbers (e.g., service_account_id now using 22) may introduce backward compatibility issues with existing serialized data. Ensure that all affected clients are updated in tandem with these changes.
string service_account_id = 22;
| string workspace_id = 24; | ||
| string domain_id = 25; | ||
| string created_at = 31; | ||
| string updated_at = 32; |
There was a problem hiding this comment.
[nitpick] Consider adding a descriptive comment for the updated_at field to clarify its purpose in tracking modifications.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Category
Description
Known issue