Reorder fields in cost_report.proto #586
Merged
ImMin5 merged 1 commit intocloudforet-io:masterfrom May 27, 2025
Merged
Conversation
…nsistency Signed-off-by: ImMin5 <mino@megazone.com>
There was a problem hiding this comment.
Pull Request Overview
This PR reorders fields in the cost_report.proto file as a bug fix and improvement.
- Reorders four fields and adjusts their field numbers
- Updates the proto file to reflect the new order and meet current business requirements
Comments suppressed due to low confidence (1)
proto/spaceone/api/cost_analysis/v1/cost_report.proto:109
- Reordering fields and changing field numbers (e.g. moving 'cost_report_config_id' from 21 to 25 and 'domain_id' from 25 to 21) may break backward compatibility with existing serialized messages. Consider verifying the impact on clients and providing a proper migration strategy if needed.
string domain_id = 21;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Category
Description
Known issue