Add WAREHOUSE option to data source enums for expanded function#587
Merged
ImMin5 merged 1 commit intocloudforet-io:masterfrom May 28, 2025
Merged
Add WAREHOUSE option to data source enums for expanded function#587ImMin5 merged 1 commit intocloudforet-io:masterfrom
ImMin5 merged 1 commit intocloudforet-io:masterfrom
Conversation
…ality Signed-off-by: ImMin5 <mino@megazone.com>
There was a problem hiding this comment.
Pull Request Overview
This PR improves the data source enums by adding a new value (WAREHOUSE) to support additional functionality.
- Adds WAREHOUSE to the enum in RegisterDataSourceRequest
- Adds WAREHOUSE to the enum in DataSourceInfo
Comments suppressed due to low confidence (2)
proto/spaceone/api/cost_analysis/v1/data_source.proto:184
- Ensure that the introduction of the new enum value 'WAREHOUSE' is documented in the proto file and in associated client code, to maintain clear API expectations.
WAREHOUSE = 3;
proto/spaceone/api/cost_analysis/v1/data_source.proto:402
- Ensure consistent usage and documentation for the new WAREHOUSE value across both enum definitions to avoid potential confusion in client-side implementation.
WAREHOUSE = 3;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Category
Description
Known issue