fix: add CostReport Status EXPIRED#590
Merged
jinyoungmoonDEV merged 1 commit intocloudforet-io:masterfrom Jun 13, 2025
Merged
Conversation
Signed-off-by: jinyoungmoonDEV <moonjinyoung.dev@gmail.com>
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new global Status enum to include an EXPIRED state for CostReport while removing duplicate status definitions in message types to centralize status management.
- Introduces a global Status enum with an additional EXPIRED value.
- Removes inline Status enums from CostReportQuery and CostReportInfo messages.
- Improves maintainability by reducing duplicated code.
Comments suppressed due to low confidence (2)
proto/spaceone/api/cost_analysis/v1/cost_report.proto:56
- [nitpick] Consider adding a descriptive comment for the EXPIRED status to clarify the intended meaning and usage conditions for future maintainability.
EXPIRED = 4;
proto/spaceone/api/cost_analysis/v1/cost_report.proto:51
- Centralizing the CostReport status definitions into a new global enum improves maintainability. Please ensure all references to the previous inline enums are updated to use this new global enum.
enum Status {
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Category
Description