fix: enum error from CostReport#591
Merged
jinyoungmoonDEV merged 1 commit intocloudforet-io:masterfrom Jun 13, 2025
Merged
Conversation
Signed-off-by: jinyoungmoonDEV <moonjinyoung.dev@gmail.com>
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an enum error in the CostReport proto definition by removing the global Status enum and reintroducing it within the CostReportQuery and CostReportInfo messages.
- Removed the global Status enum from the service definition.
- Added enum Status inline within CostReportQuery.
- Added enum Status inline within CostReportInfo to better scope the enum usage.
| } | ||
|
|
||
| message CostReportQuery { | ||
| enum Status { |
There was a problem hiding this comment.
The Status enum is now duplicated in both CostReportQuery and CostReportInfo messages. Consider refactoring by defining the enum in a shared location to avoid potential maintenance issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Category
Description