Skip to content
This repository was archived by the owner on Jan 19, 2022. It is now read-only.

config file change for default values and not to panic for unknown parameter#125

Open
krishnamk00 wants to merge 1 commit intocloudfoundry-incubator:masterfrom
krishnamk00:krishna-configFileChange
Open

config file change for default values and not to panic for unknown parameter#125
krishnamk00 wants to merge 1 commit intocloudfoundry-incubator:masterfrom
krishnamk00:krishna-configFileChange

Conversation

@krishnamk00
Copy link

In this config file all the parameters are added with the default values.
All default values are pulled from the code where it is mentioned.
it is easy to get start running PAT quickly with this file.

In the current file, there is a parameter mentioned "output" and does not seems like existing.
This creates panic. There is check inserted to ignore unknown parameter and instead take the default.

@cfdreddbot
Copy link

Hey krishna-mk!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you've already signed the CLA.

@jberkhahn
Copy link
Contributor

Hey there,
This looks pretty cool, would you mind adding a test for it though? Something in config_test that tests an incorrectly provided param, maybe?

@jberkhahn
Copy link
Contributor

Hey @Krishna-Mk

Were you interested in finishing these? If we don't hear from you soon we're going to reject these.

@krishnamk00
Copy link
Author

Hi Jonathan,

Yes, we are very interested in PAT and we are running it in our setup.
After the cloud foundry summit, this falls apart from the plate.
I will do it all those pending items in couple of days. Thanks a lot for checking back with me.

Added a check to detect the wrong parameter and not to cause panic
Added test cases for wrong parameter check
@krishnamk00 krishnamk00 force-pushed the krishna-configFileChange branch from 1466e12 to 048d86b Compare June 25, 2015 04:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants