This repository was archived by the owner on Jan 19, 2022. It is now read-only.
config file change for default values and not to panic for unknown parameter#125
Open
krishnamk00 wants to merge 1 commit intocloudfoundry-incubator:masterfrom
Open
config file change for default values and not to panic for unknown parameter#125krishnamk00 wants to merge 1 commit intocloudfoundry-incubator:masterfrom
krishnamk00 wants to merge 1 commit intocloudfoundry-incubator:masterfrom
Conversation
|
Hey krishna-mk! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you've already signed the CLA. |
Contributor
|
Hey there, |
Contributor
|
Hey @Krishna-Mk Were you interested in finishing these? If we don't hear from you soon we're going to reject these. |
Author
|
Hi Jonathan, Yes, we are very interested in PAT and we are running it in our setup. |
Added a check to detect the wrong parameter and not to cause panic Added test cases for wrong parameter check
1466e12 to
048d86b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this config file all the parameters are added with the default values.
All default values are pulled from the code where it is mentioned.
it is easy to get start running PAT quickly with this file.
In the current file, there is a parameter mentioned "output" and does not seems like existing.
This creates panic. There is check inserted to ignore unknown parameter and instead take the default.