This repository was archived by the owner on Jan 19, 2022. It is now read-only.
Fix issue: Setting a custom file name for output does nothing #115#128
Open
krishnamk00 wants to merge 2 commits intocloudfoundry-incubator:masterfrom
Open
Fix issue: Setting a custom file name for output does nothing #115#128krishnamk00 wants to merge 2 commits intocloudfoundry-incubator:masterfrom
krishnamk00 wants to merge 2 commits intocloudfoundry-incubator:masterfrom
Conversation
added 2 commits
April 27, 2015 17:32
|
Hey krishna-mk! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you've already signed the CLA. |
Contributor
|
Hey there, This looks like a good idea, but it's currently broken - you missed an ending } in logs/config.go, so it won't even compile. You also didn't write any tests describing the new feature - think you could add some? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
logging:file parameter passed was not taking as output file instead always PAT takes the default output file format always. This fix will: