Skip to content
This repository was archived by the owner on Jan 19, 2022. It is now read-only.

Fix issue: Setting a custom file name for output does nothing #115#128

Open
krishnamk00 wants to merge 2 commits intocloudfoundry-incubator:masterfrom
krishnamk00:krishna-mk-OutPutFileCreation
Open

Fix issue: Setting a custom file name for output does nothing #115#128
krishnamk00 wants to merge 2 commits intocloudfoundry-incubator:masterfrom
krishnamk00:krishna-mk-OutPutFileCreation

Conversation

@krishnamk00
Copy link

logging:file parameter passed was not taking as output file instead always PAT takes the default output file format always. This fix will:

  • Take the argument passed a output file and place it in the correct output dir.
  • If file is passed as dir/file format it checks the format and process the file, else it used to create panic.

@cfdreddbot
Copy link

Hey krishna-mk!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you've already signed the CLA.

@jberkhahn
Copy link
Contributor

Hey there,

This looks like a good idea, but it's currently broken - you missed an ending } in logs/config.go, so it won't even compile. You also didn't write any tests describing the new feature - think you could add some?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants