fix: add service_id and plan_id to OSBAPI (service) fetch endpoints#4851
Closed
blgm wants to merge 1 commit intocloudfoundry:mainfrom
Closed
fix: add service_id and plan_id to OSBAPI (service) fetch endpoints#4851blgm wants to merge 1 commit intocloudfoundry:mainfrom
blgm wants to merge 1 commit intocloudfoundry:mainfrom
Conversation
blgm
force-pushed
the
fetchparams
branch
2 times, most recently
from
ac114ba to
4683682
Compare
Add optional service_id and plan_id query parameters to fetch_service_instance and fetch_service_binding broker requests, matching the pattern used by last_operation endpoints. Enables delegate/router brokers to route fetch requests without falling back to trying all sub-brokers. While optional per OSBAPI spec, these parameters are helpful hints that CC already has available. An aim of a platform (like CC) is to make it easier to write brokers - especially stateless brokers, so low cost hints like this bring the code in line with the product aims. - [x] I have reviewed the contributing guide - [x] I have viewed, signed, and submitted the Contributor License Agreement - [x] I have made this pull request to the `main` branch - [x] I have run all the unit tests using `bundle exec rake` - [ ] I have run CF Acceptance Tests
Member
Author
|
On further investigation, these parameters (although useful) are part of the OSBAPI 2.16 spec that the cloud controller does not yet implement. Therefore it's premature to make this change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add optional service_id and plan_id query parameters to fetch_service_instance and fetch_service_binding broker requests, matching the pattern used by last_operation endpoints.
Enables delegate/router brokers to route fetch requests without falling back to trying all sub-brokers. While optional per OSBAPI spec, these parameters are helpful hints that CC already has available. An aim of a platform (like CC) is to make it easier to write brokers - especially stateless brokers, so low cost hints like this bring the code in line with the product aims.
mainbranchbundle exec rake