Skip to content

Update ctl.erb to include clock_drift_enabled - #327

Merged
chombium merged 1 commit into
cloudfoundry:mainfrom
ay901246:patch-1
Jul 24, 2026
Merged

Update ctl.erb to include clock_drift_enabled#327
chombium merged 1 commit into
cloudfoundry:mainfrom
ay901246:patch-1

Conversation

@ay901246

@ay901246 ay901246 commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Because of the BPM changes that removed ctl.erb, when the ctl.erb file was remade, it didn't include the clock_drift_enabled parameter (see: https://github.com/cloudfoundry/system-metrics-release/pull/321/changes#r3581015436).

This fix allows system metrics to correctly read clock_drift_enabled.

Description

Please include a summary of the change.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Testing performed?

  • Unit tests
  • Integration tests (tested manually by adding clock drift enabled = true in a vm)
  • Acceptance tests

Checklist:

  • This PR is being made against the main branch, or relevant version branch
  • I have made corresponding changes to the documentation
  • I have added testing for my changes

If you have any questions, or want to get attention for a PR or issue please reach out on the #logging-and-metrics channel in the cloudfoundry slack

Because of the BPM changes that removed ctl.erb, when the ctl.erb file was remade, it didn't include the clock_drift_enabled parameter (see: https://github.com/cloudfoundry/system-metrics-release/pull/321/changes#r3581015436).

This fix allows system metrics to correctly read clock_drift_enabled via ctl.erb and adds true/false unit tests.

Co-authored-by: Cursor <cursoragent@cursor.com>

@jorbaum jorbaum left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@chombium
chombium merged commit a96562d into cloudfoundry:main Jul 24, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

3 participants