Implement From conversion for non-empty hardcoded arrays#80
Open
bitdriftr wants to merge 1 commit intocloudhead:masterfrom
Open
Implement From conversion for non-empty hardcoded arrays#80bitdriftr wants to merge 1 commit intocloudhead:masterfrom
bitdriftr wants to merge 1 commit intocloudhead:masterfrom
Conversation
Collaborator
|
This is nice, and I played around with it myself. I made some changes, but because GitHub is hostile to making new revisions to someone else's fork I had to create a new PR myself #81. This led me to realising that constantly using However, I cannot merge this, and it seems like I'm not a maintainer on this repository, however I do have publishing rights on crates.io. So for the time being I've pushed these changes to my fork https://github.com/FintanH/nonempty. Either @cloudhead needs to add me as maintainer or I might have to maintain the crate via my fork instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
Fromconversion for rust arrays of generic size. Thanks to const expressions, we can ensure the size is not zero, making the conversion infallible.