refactor: memoize highlight result to avoid redundant tokenization #108
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
useMemoto cache the syntax highlighting result in the CodeView component, preventing expensive re-tokenization on every render.Problem
The
highlightfunction (which uses ace-code's tokenizer) runs on every render ofInternalCodeView, even whencontenthasn't changed. This is wasteful because:Solution
Wrap the highlight call in
useMemowith[content, highlight]as dependencies:Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.