Skip to content

refactor: use native padStart() in padLeftZeros utility #4202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
TrevorBurnham wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor: use native padStart() in padLeftZeros utility #4202

TrevorBurnham wants to merge 1 commit into from

Conversation

@TrevorBurnham
Copy link
Contributor

@TrevorBurnham TrevorBurnham commented Jan 25, 2026

Description

This PR replaces a while loop with padStart for cleaner, more idiomatic code. The padStart method has been widely supported for several years now.

How has this been tested?

This utility function has extensive unit test coverage.

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@TrevorBurnham
refactor: use native padStart() in padLeftZeros utility
8d9aec6 
Replace manual while loop with String.prototype.padStart() for cleaner,
more idiomatic code. This native ES2017 method provides the same
functionality with better readability.
@TrevorBurnham TrevorBurnham requested a review from a team as a code owner January 25, 2026 00:58
@TrevorBurnham TrevorBurnham requested review from pan-kot and removed request for a team January 25, 2026 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pan-kot pan-kot Awaiting requested review from pan-kot pan-kot is a code owner automatically assigned from cloudscape-design/cloudscape-dev

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@TrevorBurnham