fix: disable automatic CommitTimestamp injection in default template#187
Merged
fix: disable automatic CommitTimestamp injection in default template#187
Conversation
Managing behavior for fields that should be set only once (e.g., `CreatedAt`) was difficult. Previously, the default template attempted to set `spanner.CommitTimestamp` every time, even for NOT NULL columns, which made it cumbersome to use. This change delegates `AllowCommitTimestamp` control to Custom Templates. The default template will no longer perform any automatic timestamp operations.
vvakame
approved these changes
Jan 9, 2026
Collaborator
vvakame
left a comment
vvakame
left a comment
There was a problem hiding this comment.
I hesitated a little, but I think I can accept it.
Collaborator
Author
|
@vvakame It is a breaking change, so it is a tough call, but currently it is so difficult to use that I think it is at a level where it can be considered a bug. |
Collaborator
|
how about v0.8.0? |
Collaborator
Author
|
OK! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Managing behavior for fields that should be set only once (e.g.,
CreatedAt) was difficult. Previously, the default template attempted to setspanner.CommitTimestampevery time, even for NOT NULL columns, which made it cumbersome to use.This change delegates
AllowCommitTimestampcontrol to Custom Templates. The default template will no longer perform any automatic timestamp operations.refs