This repository was archived by the owner on Mar 17, 2026. It is now read-only.
Add normalization to suppress false positives for booleans in diff mode#3
Merged
clefrancq merged 1 commit intoflow_configfrom Apr 15, 2025
Merged
Conversation
basbeu
approved these changes
Apr 14, 2025
damu46
approved these changes
Apr 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses: https://projectportal.elca.ch/jira/browse/CLOUDTRUST-5987
Boolean values in dictionaries show up as false positive diffs when quotes are not included in script.
This PR adds a util
normalize_diffmode_boolean(dictionary)that converts the boolean values in the dictionary to lower-case strings, which will match the API response.Modules corrected
keycloak_client: attributes, protocol mapper configkeycloak_clientscope: protocol mapper config