This repository was archived by the owner on Mar 17, 2026. It is now read-only.
[CLOUDTRUST-6203] Set priority in authentication flow creation#4
Merged
basbeu merged 1 commit intoflow_configfrom May 12, 2025
Merged
[CLOUDTRUST-6203] Set priority in authentication flow creation#4basbeu merged 1 commit intoflow_configfrom
basbeu merged 1 commit intoflow_configfrom
Conversation
damu46
reviewed
May 6, 2025
| else: | ||
| levels_indices[current_level] += 1 | ||
| new_exec["index"] = levels_indices[current_level] | ||
| if "priority" not in new_exec or new_exec["priority"] is None: |
There was a problem hiding this comment.
Wouldn't it be better if this "computation" was done in the "flow_parser" module?
Author
There was a problem hiding this comment.
I do not know, because I need at least to update this module to take the priority as module parameters. Upstream, they handled the priority. If one day we will realign ourselves on upstream, the priority will be handled so I think it is fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.