Skip to content
This repository was archived by the owner on Mar 17, 2026. It is now read-only.

Compare on normalised clients#8

Merged
damu46 merged 1 commit intoflow_configfrom
fix/client_changed_status_in_non_check_mode
Sep 23, 2025
Merged

Compare on normalised clients#8
damu46 merged 1 commit intoflow_configfrom
fix/client_changed_status_in_non_check_mode

Conversation

@damu46
Copy link
Copy Markdown

@damu46 damu46 commented Sep 23, 2025

Currently, the "changed" flag is set to False on an update only if the remote and local representations are exact matches. This is an issue as:

  • Some lists orders do not matter (e.g. redirect URIs)
  • This is incoherent with the rest of the implementation which normalizes the structure beforehand
  • This is incoherent with the diff which is normalized and sanitized

@basbeu basbeu requested review from basbeu and clefrancq September 23, 2025 14:48
@damu46 damu46 merged commit 3a6738b into flow_config Sep 23, 2025
1 of 2 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@clefrancq clefrancq Awaiting requested review from clefrancq

1 more reviewer

@basbeu basbeu basbeu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@damu46 @basbeu