Skip to content

Update vmodl with vsphere 8 APIs#1

Open
vishwasja wants to merge 2 commits into
cloudvolumes:masterfrom
vishwasja:update_vmodl_with_vc8_apis
Open

Update vmodl with vsphere 8 APIs#1
vishwasja wants to merge 2 commits into
cloudvolumes:masterfrom
vishwasja:update_vmodl_with_vc8_apis

Conversation

@vishwasja

@vishwasja vishwasja commented Feb 15, 2023

Copy link
Copy Markdown

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests?
  2. Have you lint your code locally prior to submission?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@Lasvad Lasvad left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Vishwas walked me through the changes to the vmodl.db file and how it was generated.

@vishwasja vishwasja requested a review from Lasvad March 7, 2023 19:12

@Lasvad Lasvad left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the summary of changes you have made to the PR description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants