Conversation
|
Hello, thanks for the work. I am on vacation currently but can check in for a review in the next week. I assume you've already used the new APIs and they work for your own needs? |
|
Hi @danopia! basically, I was writing a script that's using the Teams and the Users API - however, when I found this package I only found the latter being implemented - so I added the former. While I wrote the script I was able to successfully invoke all of the Teams API calls at least once (+ that one v2/users call that I added myself). Does that answer your question? |
danopia
left a comment
There was a problem hiding this comment.
I have two specific requests on this
| // Common API client contract | ||
| interface ApiClient { | ||
| fetchJson(opts: { | ||
| method: "GET" | "POST" | "DELETE"; |
There was a problem hiding this comment.
It looks like this is the first DELETE call in this project, and so the new method needs to be also added to client.ts:
https://github.com/cloudydeno/deno-datadog_api/blob/657811ec549cd4c16a5cdb096c07118aff45244e/client.ts#L40
v2/teams.ts
Outdated
| attributes: { | ||
| name: name, | ||
| handle: handle | ||
| }, |
There was a problem hiding this comment.
I see that there are additional possible attributes for this API, so perhaps we can accept a second optional parameter extraAttributes that lets the caller override handle and/or pass more attributes for the team.
| attributes: { | |
| name: name, | |
| handle: handle | |
| }, | |
| attributes: { | |
| name: name, | |
| handle: handle, | |
| ...extraAttributes, | |
| }, |
|
hey, checking back in because I'm going thru all my modules to switch them over to JSR. Do you have more commits to push here? I could also merge and finish the nits separately.. |
Hi! I've noted that in this repo there's no API for v2/Teams, so I added all the GET calls - and also some of the other ones. Please, be kind: this is my literal first OSS contribution in typescript 😅