fix: add mcpPromptMode capability — stop dead MCP docs in CatAgent - #60
Open
bouillipx wants to merge 2 commits into
Open
fix: add mcpPromptMode capability — stop dead MCP docs in CatAgent#60bouillipx wants to merge 2 commits into
bouillipx wants to merge 2 commits into
Conversation
|
To use Codex here, create an environment for this repo. |
…o CatAgent CatAgent had mcpSupport=true but couldn't actually use MCP tools (no MCP client) or HTTP callbacks (no shell/curl). Both config states produced dead documentation in the prompt: - mcpSupport=true → S13 MCP_TOOLS_SECTION injected (unusable tools) - mcpSupport=false → C1 HTTP callback injected (no curl available) Add mcpPromptMode() to AgentService interface with three modes: - 'native-mcp': inject S13 docs (Claude) - 'http-callback': inject C1 callback (Codex/Gemini) - 'none': inject neither (CatAgent pre-bridge) Centralized resolveMcpPromptInjection() helper replaces scattered boolean logic in both route-serial and route-parallel. Legacy providers without the new capability fall back to existing mcpSupport && mcpServerPath logic (zero back-compat break). Closes #59 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Address codex review P2 — new test block formatter compliance. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
bouillipx
force-pushed
the
fix/catagent-mcp-prompt-mode
branch
from
July 8, 2026 02:52
3a417e4 to
1f772d6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mcpSupport: truebut couldn't use MCP tools or HTTP callbacks — both config states injected unusable documentation into the promptmcpPromptMode()capability toAgentServiceinterface with three modes:'native-mcp'/'http-callback'/'none''none'— neither S13 (MCP_TOOLS_SECTION) nor C1 (HTTP callback) docs are injectedresolveMcpPromptInjection()helper replaces scattered boolean logic in bothroute-serialandroute-parallelmcpSupport && mcpServerPathlogic (zero back-compat break)Design Gate
Passed by @codex — see thread_mnlhyrdap19ne3r3 for full design review (2 rounds, P1s addressed).
Test plan
resolveMcpPromptInjection: none/native-mcp/http-callback modes, legacy fallbacks, antigravity special case, capability-overrides-configpnpm lintcleanCloses #59
🐾 [宪宪/opus46]
🤖 Generated with Claude Code