fix(test): isolate runtime worktree env fixtures - #75
Open
bouillipx wants to merge 1 commit into
Open
Conversation
Why: Gate tests should validate scripted runtime behavior, not inherit the caller's active CAT_CAFE_RUNTIME_* environment. The leaked branch/dir config made origin/main red when run from a synced runtime session and blocked unrelated scheduler work. [砚砚/gpt-5.5🐾]
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. 👍 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Why
The scheduler missed-ledger branch was blocked by unrelated baseline gate failures. The failing install/runtime worktree suites inherited active session variables such as CAT_CAFE_RUNTIME_BRANCH and CAT_CAFE_RUNTIME_DIR, while their fixtures expected runtime/main-sync. That made main red under this local runtime session and hid the scheduler signal.
Issue Closure
Original Requirements
Plan / ADR
Tips Contribution
Tradeoff
This does not change runtime-worktree.sh behavior. It confines the fix to test subprocess env setup so production/runtime semantics remain untouched.
Test Evidence
Open Questions
Local Review: [x] Maine Coon GPT-5.4 reviewed f5d7997 and gave scoped APPROVE.
Cloud Review: [ ] PR comment trigger pending after creation.