Skip to content

[Bugfix #664] Read issue number from DB, not builder name#665

Merged
waleedkadous merged 2 commits intomainfrom
builder/bugfix-664-dashboard-extract-issue-number
Apr 13, 2026
Merged

[Bugfix #664] Read issue number from DB, not builder name#665
waleedkadous merged 2 commits intomainfrom
builder/bugfix-664-dashboard-extract-issue-number

Conversation

@waleedkadous
Copy link
Copy Markdown
Contributor

Fixes #664

Root Cause

The dashboard's Issue column extracted issue numbers by regex-matching builder names against known protocol prefixes (spir-NNN, aspir-NNN, bugfix-NNN, etc.). Unknown protocols like research didn't match, so their issue number showed as the full builder name.

Fix

In getOverview(), after discovering builders from the filesystem, enrich issueId from the DB's issue_number column. The builders table already stores this value at spawn time. This is protocol-agnostic — works for any current or future protocol without regex updates.

Falls back gracefully to the regex-parsed value when the DB is unavailable (e.g., no Tower running).

Test Plan

  • Added regression test: unknown protocol (research-533-*) gets correct issueId from DB
  • Added test: DB value overrides regex-parsed value for known protocols
  • Added test: falls back to regex when DB has no issue_number
  • All 129 existing overview tests pass
  • Full build succeeds
  • Full test suite passes (excluding known flaky E2E tests)

@waleedkadous waleedkadous merged commit a799a80 into main Apr 13, 2026
6 checks passed
@waleedkadous waleedkadous deleted the builder/bugfix-664-dashboard-extract-issue-number branch April 13, 2026 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dashboard: extract issue number from builder metadata, not builder name

1 participant