You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Source directory of the backup is getting archived in a tar archive and compressed with gzip resulting in a .tar.gzip file at the configured destination.
Still missing:
check if tests are needed and if yes implement them
What about symlinks? They are not followed, but the callback is still called for symlinks, if I'm not mistaken. For example, rsync -a preserve symlinks among other things. lifeboat should offer this option too.
And on the topic of rsync, maybe it can be used as an external tool if available. You know, reinventing the wheel and yada yada 😉
What about symlinks? They are not followed, but the callback is still called for symlinks, if I'm not mistaken. For example, rsync -a preserve symlinks among other things. lifeboat should offer this option too.
And on the topic of rsync, maybe it can be used as an external tool if available. You know, reinventing the wheel and yada yada 😉
Hey,
first of all thanks for having a look :)
looks like filepath.WalkDir is indeed the better choice here as appearently it is a more performant/efficient version of filepath.Walk - thanks for pointing it out
Symlinks are a complicated one in our use case as we want to support abitrary destinations for a backup. What happens f.e. when the file should be "backupped" into an S3 where the Symlink might point to a non-existing file? One idea could be to actually include the followed file into the final tar?
As for using rsync: the idea was to depend on as few external tools as possible so it can be used in as many environments as possible without the need for other tools.
Regarding the symlinks, I would do something similar to the tar utility itself, i.e. include the symlinks as soft-links in the archive. Here we have two cases:
either the links are relative and point to some file inside the archive => they would work after unpacking
or they are absolute and point to something outside => they would be broken after unpacking
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #16
Source directory of the backup is getting archived in a tar archive and compressed with gzip resulting in a
.tar.gzipfile at the configured destination.Still missing: