Split a text into smaller pieces and make a single document of them.#685
Merged
Split a text into smaller pieces and make a single document of them.#685
Conversation
Contributor
|
LGTM @kwalcock. Thanks! |
Member
Author
|
@myedibleenso, this shows a couple of additional ways that your |
Member
Author
|
This shouldn't change any behavior or affect performance, so I'd like to add it if only to preserve the idea, whether or not @myedibleenso or anyone ever uses it. I'm less certain about the alternative, #676. Perhaps it can be looked at again now that it has been mulled over for a couple of months. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a draft because the changes were concentrated in Processor when they really should be distributed between Document and Sentence. However, it shows that the processors project does not necessarily need to be changed at all to achieve the functionality. The test cases should show the intended use. This is related to #676, but doesn't necessarily replace it. I should double check that no offset values have been missed.