Skip to content

Add L1TSC82ProngJetModel#10337

Open
henripetrow wants to merge 3 commits intocms-sw:IB/CMSSW_16_1_X/masterfrom
henripetrow:IB/CMSSW_16_1_X/master
Open

Add L1TSC82ProngJetModel#10337
henripetrow wants to merge 3 commits intocms-sw:IB/CMSSW_16_1_X/masterfrom
henripetrow:IB/CMSSW_16_1_X/master

Conversation

@henripetrow
Copy link

This PR adds one new package for an upcoming CMSSW PR for the Phase 2 Level 1 Trigger 2-Prong Jet Tagging Model.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @henripetrow for branch IB/CMSSW_16_1_X/master.

@akritkbehera, @cmsbuild, @iarspider, @raoatifshad, @smuzaffar can you please review it and eventually sign? Thanks.
@missirol, @mmusich this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 11, 2026

cms-bot internal usage

@@ -0,0 +1,6 @@
<tool name="l1tsc82prongjetmodel" version="@TOOL_VERSION@" revision="1">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@henripetrow , please add .xml extension to this file i.e. it should be l1tsc82prongjetmodel.xml

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the .xml extension.

@smuzaffar
Copy link
Contributor

assign l1

@cms-sw/l1-l2 , if no objections on this addition then please start the tests here

@cmsbuild
Copy link
Contributor

New categories assigned: l1

@BenjaminRS,@quinnanm you have been requested to review this Pull request/Issue and eventually sign? Thanks

@@ -0,0 +1,13 @@
### RPM external L1TSC82ProngJetModel 0.0.0
Source: https://github.com/cms-hls4ml/%{n}/archive/refs/tags/v%{realversion}.tar.gz
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On a quick look the repository seems to contain binary files (.so, .o`), I'd suggest to clean them up.

Also many files seem to contain code that is not in a unique namespace increasing the risk for ODR violations. For example

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed binary files. Looking on changing the namespace.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2026

Pull request #10337 was updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants