Add L1TSC82ProngJetModel#10337
Add L1TSC82ProngJetModel#10337henripetrow wants to merge 3 commits intocms-sw:IB/CMSSW_16_1_X/masterfrom
Conversation
|
A new Pull Request was created by @henripetrow for branch IB/CMSSW_16_1_X/master. @akritkbehera, @cmsbuild, @iarspider, @raoatifshad, @smuzaffar can you please review it and eventually sign? Thanks. |
|
cms-bot internal usage |
| @@ -0,0 +1,6 @@ | |||
| <tool name="l1tsc82prongjetmodel" version="@TOOL_VERSION@" revision="1"> | |||
There was a problem hiding this comment.
@henripetrow , please add .xml extension to this file i.e. it should be l1tsc82prongjetmodel.xml
|
assign l1 @cms-sw/l1-l2 , if no objections on this addition then please start the tests here |
|
New categories assigned: l1 @BenjaminRS,@quinnanm you have been requested to review this Pull request/Issue and eventually sign? Thanks |
| @@ -0,0 +1,13 @@ | |||
| ### RPM external L1TSC82ProngJetModel 0.0.0 | |||
| Source: https://github.com/cms-hls4ml/%{n}/archive/refs/tags/v%{realversion}.tar.gz | |||
There was a problem hiding this comment.
On a quick look the repository seems to contain binary files (.so, .o`), I'd suggest to clean them up.
Also many files seem to contain code that is not in a unique namespace increasing the risk for ODR violations. For example
There was a problem hiding this comment.
Removed binary files. Looking on changing the namespace.
|
Pull request #10337 was updated. |
This PR adds one new package for an upcoming CMSSW PR for the Phase 2 Level 1 Trigger 2-Prong Jet Tagging Model.