Skip to content

remove build-system env which is now set via cmsBuild#10414

Merged
smuzaffar merged 1 commit intoIB/CMSSW_16_1_X/masterfrom
rpmbuild-cpu-limit
Mar 12, 2026
Merged

remove build-system env which is now set via cmsBuild#10414
smuzaffar merged 1 commit intoIB/CMSSW_16_1_X/masterfrom
rpmbuild-cpu-limit

Conversation

@smuzaffar
Copy link
Contributor

@smuzaffar smuzaffar commented Mar 12, 2026

cmsBuild now sets the build-system env o control the parallel jobs to run. This is useful for pypi based packages wheresome times we do not have control over the backend which runs the build system commands.

Thsi PR proposes to drop these env from cmsdist as these are now set by cmsBuild

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar for branch IB/CMSSW_16_1_X/master.

@akritkbehera, @iarspider, @raoatifshad, @smuzaffar can you please review it and eventually sign? Thanks.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 12, 2026

cms-bot internal usage

@cmsbuild
Copy link
Contributor

Pull request #10414 was updated.

@smuzaffar
Copy link
Contributor Author

please test

@smuzaffar smuzaffar force-pushed the rpmbuild-cpu-limit branch from b748f33 to d78d67b Compare March 12, 2026 12:37
@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

Pull request #10414 was updated.

@smuzaffar smuzaffar changed the title Control the number of core used by rpmbuild and rpmdeps remove build-system env which is now set via cmsBuild Mar 12, 2026
@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2003ee/51920/summary.html
COMMIT: d78d67b
CMSSW: CMSSW_16_1_X_2026-03-11-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/10414/51920/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2003ee/51920/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2003ee/51920/git-merge-result

Comparison Summary

Summary:

  • You potentially added 9 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 1 differences found in the comparisons
  • DQMHistoTests: Total files compared: 53
  • DQMHistoTests: Total histograms compared: 4185208
  • DQMHistoTests: Total failures: 116
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4185072
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
  • Checked 227 log files, 198 edm output root files, 53 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor Author

+externals

@smuzaffar smuzaffar merged commit 539aacc into IB/CMSSW_16_1_X/master Mar 12, 2026
8 checks passed
@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_16_1_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @ftenchini, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants