[13.1.X] Update correctionlib to 2.7#9907
[13.1.X] Update correctionlib to 2.7#9907nsmith- wants to merge 1 commit intocms-sw:IB/CMSSW_13_1_X/masterfrom
Conversation
Backporting to older CMSSW versions before we auto-update packages regularly
|
A new Pull Request was created by @nsmith- for branch IB/CMSSW_13_1_X/master. @cmsbuild, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks. |
|
cms-bot internal usage |
|
@nsmith- , this should first go in to development IB, i.e. CMSSW_15_1_X, before backporting it to production releases like CMSWW_13.1.X. Can you please open a PR for IB/cMSSW_15_1_X/master branch? |
|
@smuzaffar the version of correctionlib is already at a much more recent version in the the development IB: Line 66 in c4e8bac This is a backport. If the issue is with 2.6.4 vs. 2.7 I can also bump it to 2.7 there as well |
@nsmith- , yes please first bump it in 15.1.X. also I see you have added few more pip packages . Make sure to get those updates for 15.1.X too and note that newly added packages are not build automatically. You have to add them as dependency of package which actually need/use these |
|
It looks like another auto-update to 15_1_X has happened in the meantime and now correctionlib is v2.7 there: |
All those are just dependencies declared by the package or its dependencies. Again, in 15_1_X, they are all already there. I don't really understand what you are saying here. Why can't we just let pip resolve the environment from this requirements file? |
|
please test Do we still need this in 13.1.X ? |
|
-1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-63f67d/51940/summary.html Failed External BuildI found compilation error when building: * The action "build-build-external+py3-typing-extensions+4.14.0-0278082b5885ef1fdb4d31cc3057f9c8" was not completed successfully because Failed to build py3-typing-extensions. Log file in /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc11/external/py3-typing-extensions/4.14.0-0278082b5885ef1fdb4d31cc3057f9c8/log. Final lines of the log file: note: This error originates from a subprocess, and is likely not a problem with pip. full command: /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc11/external/python3/3.9.14-76a14295dd5255228210eb596893b98c/bin/python3 /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc11/external/py3-pip/23.1.1-c1408bab1febb2da1ed5867dfdc1d3e7/lib/python3.9/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py prepare_metadata_for_build_wheel /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc11/external/py3-typing-extensions/4.14.0-0278082b5885ef1fdb4d31cc3057f9c8/cmsdist-tmp/tmpeb7mbhx9 cwd: /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc11/external/py3-typing-extensions/4.14.0-0278082b5885ef1fdb4d31cc3057f9c8/cmsdist-tmp/pip-req-build-94jc6ctb Preparing metadata (pyproject.toml): finished with status 'error' error: metadata-generation-failed Encountered error while generating package metadata. > See above for output. note: This is an issue with the package mentioned above, not pip. |
Backporting to older CMSSW versions before we auto-update packages regularly.
If this works well and is correct I'll propagate it to other versions.