Skip to content

move HLTADFilter out of HLTrigger subsystem into its own package#50346

Merged
cmsbuild merged 1 commit intocms-sw:masterfrom
mmusich:mm_dev_modeAXO
Mar 11, 2026
Merged

move HLTADFilter out of HLTrigger subsystem into its own package#50346
cmsbuild merged 1 commit intocms-sw:masterfrom
mmusich:mm_dev_modeAXO

Conversation

@mmusich
Copy link
Copy Markdown
Contributor

@mmusich mmusich commented Mar 9, 2026

PR description:

As agreed in #50099 moved HLTADFilter out of HLTrigger into its own package RecoML/AnomalyDetection.
In partial reponse to #49955 I make the module (now called AXOScoreProducer ) to produce into the event the score of the anomaly detection (on which we can e.g. then cut at HLT with the filter HLTFloatThresholdFilter introduced at #50271).

PR validation:

cmssw compiles

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, to be backported to CMSSW_16_0_X.

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Mar 9, 2026

cms-bot internal usage

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Mar 9, 2026

@mmusich
Copy link
Copy Markdown
Contributor Author

mmusich commented Mar 9, 2026

@cmsbuild, please test

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Mar 9, 2026

A new Pull Request was created by @mmusich for master.

It involves the following packages:

  • HLTrigger/HLTfilters (hlt)
  • RecoML/AnomalyDetection (****)

The following packages do not have a category, yet:

RecoML/AnomalyDetection
Please create a PR for https://github.com/cms-sw/cms-bot/blob/master/categories_map.py to assign category

@Martin-Grunewald, @mmusich can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Mar 9, 2026

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-abff1d/51853/summary.html
COMMIT: fae4434
CMSSW: CMSSW_16_1_X_2026-03-09-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/50346/51853/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@mmusich
Copy link
Copy Markdown
Contributor Author

mmusich commented Mar 9, 2026

+hlt

@cmsbuild
Copy link
Copy Markdown
Contributor

Pull request #50346 was updated. @Moanwar, @hjkwon260, @jfernan2, @mandrenguyen, @srimanob, @valsdav, @y19y19 can you please check and sign again.

@ftenchini
Copy link
Copy Markdown

Hi, we will build the next prerelease, CMSSW_16_1_0_pre3, in a couple of days.
This is usually the last prerelease we allow new features in.

If you'd like this PR to be included into 16_1_0 and think this is feasible to converge within 1-2 days, please let us know.

Alternatively, this can always go into a future 16_1_X build.

@mmusich
Copy link
Copy Markdown
Contributor Author

mmusich commented Mar 10, 2026

just pinging kindly @cms-sw/reconstruction-l2 and @cms-sw/ml-l2 (they already agreed on the cms-bot PR cms-sw/cms-bot#2701, so I guess this one would be OK)

@Moanwar
Copy link
Copy Markdown
Contributor

Moanwar commented Mar 10, 2026

+1

@hjkwon260
Copy link
Copy Markdown
Contributor

+ml

@cmsbuild
Copy link
Copy Markdown
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @ftenchini, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@ftenchini
Copy link
Copy Markdown

+1

@dan131riley
Copy link
Copy Markdown
Contributor

BuildFile.xml needs a dependency on DataFormats/ParticleFlowCandidate.

#include "DataFormats/ParticleFlowCandidate/interface/PFCandidate.h"

UBSAN actually needs the symbol:

>> Building edm plugin tmp/el8_amd64_gcc13/src/RecoML/AnomalyDetection/plugins/RecoMLAnomalyDetectionPlugins/libRecoMLAnomalyDetectionPlugins.so
/data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc13/external/gcc/13.4.0-6908cfdf803923e783448096ca4f0923/bin/c++ -O3 -pthread -pipe -Werror=main -Werror=pointer-arith -Werror=overlength-strings -Wno-vla -Werror=overflow -std=c++20 -ftree-vectorize -Werror=array-bounds -Werror=format-contains-nul -Werror=type-limits -fvisibility-inlines-hidden -fno-math-errno --param vect-max-version-for-alias-checks=50 -Xassembler --compress-debug-sections -Wno-error=array-bounds -Warray-bounds -fuse-ld=bfd -march=x86-64-v3 -felide-constructors -fmessage-length=0 -Wall -Wno-non-template-friend -Wno-long-long -Wreturn-type -Wextra -Wpessimizing-move -Wclass-memaccess -Wno-cast-function-type -Wno-unused-but-set-parameter -Wno-ignored-qualifiers -Wno-unused-parameter -Wunused -Wparentheses -Werror=return-type -Werror=unused-value -Werror=unused-label -Werror=address -Werror=format -Werror=sign-compare -Werror=write-strings -Werror=delete-non-virtual-dtor -Werror=strict-aliasing -Werror=narrowing -Werror=unused-but-set-variable -Werror=reorder -Werror=unused-variable -Werror=conversion-null -Werror=return-local-addr -Wnon-virtual-dtor -Werror=switch -fdiagnostics-show-option -Wno-unused-local-typedefs -Wno-attributes -Wno-psabi -fno-omit-frame-pointer -fsanitize=undefined -fsanitize=builtin -fsanitize=pointer-overflow -DEIGEN_DONT_PARALLELIZE -DEIGEN_MAX_ALIGN_BYTES=64 -DALPAKA_DEFAULT_HOST_MEMORY_ALIGNMENT=128 -DALPAKA_DISABLE_VENDOR_RNG -DALPAKA_HAS_STD_ATOMIC_REF -Wno-error=unused-variable -DBOOST_DISABLE_ASSERTS -g -shared -Wl,-E    -Wl,-z,defs     tmp/el8_amd64_gcc13/src/RecoML/AnomalyDetection/plugins/RecoMLAnomalyDetectionPlugins/AXOScoreProducer.cc.o -o tmp/el8_amd64_gcc13/src/RecoML/AnomalyDetection/plugins/RecoMLAnomalyDetectionPlugins/libRecoMLAnomalyDetectionPlugins.so -Wl,-E -Wl,--hash-style=gnu -Wl,--as-needed -Wl,-z,noexecstack -Wl,-no-as-needed -lpthread -Wl,-as-needed -L/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/05f2652f15b249fa17e4d8f1bbf225a4/opt/cmssw/el8_amd64_gcc13/cms/cmssw/CMSSW_17_0_UBSAN_X_2026-04-17-2300/biglib/el8_amd64_gcc13 -L/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/05f2652f15b249fa17e4d8f1bbf225a4/opt/cmssw/el8_amd64_gcc13/cms/cmssw/CMSSW_17_0_UBSAN_X_2026-04-17-2300/lib/el8_amd64_gcc13 -L/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/05f2652f15b249fa17e4d8f1bbf225a4/opt/cmssw/el8_amd64_gcc13/cms/cmssw/CMSSW_17_0_UBSAN_X_2026-04-17-2300/external/el8_amd64_gcc13/lib -L/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/05f2652f15b249fa17e4d8f1bbf225a4/opt/cmssw/el8_amd64_gcc13/cms/cmssw/CMSSW_17_0_UBSAN_X_2026-04-17-2300/static/el8_amd64_gcc13 -lDataFormatsMuonReco -lDataFormatsRecoCandidate -lDataFormatsEgammaReco -lDataFormatsGsfTrackReco -lDataFormatsVertexReco -lDataFormatsTrackReco -lDataFormatsGEMRecHit -lDataFormatsTrackCandidate -lDataFormatsCSCRecHit -lDataFormatsDTRecHit -lDataFormatsTrajectorySeed -lDataFormatsTrackingRecHit -lDataFormatsTrackerCommon -lGeometryCommonTopologies -lDataFormatsBeamSpot -lDataFormatsCaloTowers -lDataFormatsEcalRecHit -lDataFormatsGeometryCommonDetAlgo -lDataFormatsSiStripCluster -lDataFormatsCandidate -lDataFormatsDTDigi -lDataFormatsEcalDigi -lDataFormatsGeometrySurface -lDataFormatsTrajectoryState -lDataFormatsCLHEP -lDataFormatsCaloRecHit -lDataFormatsEcalDetId -lDataFormatsForwardDetId -lDataFormatsGeometryVector -lDataFormatsHcalDetId -lDataFormatsMuonDetId -lDataFormatsSiPixelDetId -lDataFormatsSiStripDetId -lFWCoreFramework -lDataFormatsDetId -lDataFormatsFEDRawData -lDataFormatsMath -lDataFormatsScouting -lDataFormatsSiPixelCluster -lDataFormatsSiStripDigi -lFWCoreCommon -lFWCoreServiceRegistry -lDataFormatsCommon -lFWCoreParameterSet -lFWCoreAbstractServices -lFWCoreMessageLogger -lDataFormatsProvenance -lFWCoreConcurrency -lFWCorePluginManager -lFWCoreReflection -lHeterogeneousCoreAlpakaInterface -lPhysicsToolsPyTorch -lDataFormatsSoATemplate -lFWCoreUtilities -lFWCoreVersion -lGenVector -lMathMore -lTree -lNet -lThread -lMathCore -lRIO -lSmatrix -lboost_program_options -Wl,--push-state -Wl,--no-as-needed -ltorch -Wl,--pop-state -Wl,--push-state -Wl,--no-as-needed -ltorch_cpu -Wl,--pop-state -Wl,--push-state -Wl,--no-as-needed -lc10 -Wl,--pop-state -lCore -lboost_thread -lboost_date_time -lCLHEP -lpcre -lbz2 -lgsl -luuid -lprotobuf -ltbb -llzma -lz -lfmt -lcms-md5 -lopenblas -lcrypt -ldl -lrt -ltinyxml2
  /data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc13/external/gcc/13.4.0-6908cfdf803923e783448096ca4f0923/bin/../lib/gcc/x86_64-redhat-linux-gnu/13.4.0/../../../../x86_64-redhat-linux-gnu/bin/ld.bfd: tmp/el8_amd64_gcc13/src/RecoML/AnomalyDetection/plugins/RecoMLAnomalyDetectionPlugins/AXOScoreProducer.cc.o:(.data.rel+0x1318): undefined reference to `typeinfo for reco::PFCandidate'
 collect2: error: ld returned 1 exit status
  gmake: *** [tmp/el8_amd64_gcc13/src/RecoML/AnomalyDetection/plugins/RecoMLAnomalyDetectionPlugins/libRecoMLAnomalyDetectionPlugins.so] Error 1
 Leaving library rule at src/RecoML/AnomalyDetection/plugins

@mmusich
Copy link
Copy Markdown
Contributor Author

mmusich commented Apr 20, 2026

BuildFile.xml needs a dependency on DataFormats/ParticleFlowCandidate.

There's already a PR for that #50722

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants