Add wide option for badges, modularise badge rendering and avoid badge gaps#855
Open
milanlakhani wants to merge 1 commit intocncf:masterfrom
Open
Add wide option for badges, modularise badge rendering and avoid badge gaps#855milanlakhani wants to merge 1 commit intocncf:masterfrom
milanlakhani wants to merge 1 commit intocncf:masterfrom
Conversation
Signed-off-by: Milan Lakhani <mlakhani14@bloomberg.net>
✅ Deploy Preview for landscapeapp ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ensures that there are no gaps when some badges on the left handside of the dialog box aren't used, by only allocating a div when the badge is in use.
This also adds a boolean setting,
wide_badges, that can allow the badges to be positioned one on top of the other rather than in side by side pairs. This can be especially useful when a badge contains a lot of text.If
wide_badgesis not set, it is assumed to be false.The placement of the
wide_badgesconfig insettings.ymlis as follows:CC @michaelmoss @awright @GeriG966 @danielsilverstone-ct @abhirampataru