Skip to content

Roll call maintainer selection bugfix#99

Merged
RobertKielty merged 2 commits intocncf:mainfrom
RobertKielty:roll-call-selection-bug
Mar 16, 2026
Merged

Roll call maintainer selection bugfix#99
RobertKielty merged 2 commits intocncf:mainfrom
RobertKielty:roll-call-selection-bug

Conversation

@RobertKielty
Copy link
Copy Markdown
Collaborator

@RobertKielty RobertKielty commented Mar 16, 2026

fixes #96 using two changes...

  1. splits project reconciliation into dedicated route-backed sections under /projects/[id]/*, covering github, dot-project, fossa, mailing-maintainers, mailing-security, docs, slack, and discord; replaces the old in-page section switching model with route-backed navigation and adds BDD coverage to verify each route, its header, and its shallow body content.

  2. improves route-transition performance by moving the shared project client into a persistent layout.tsx at /projects/[id]. This keeps the project shell and shared project state mounted while navigating between sections, avoiding repeated remounts and redundant reads of /api/projects/:id, /api/me, and /api/companies.

  which allows sectional content to manage its own state
  fixes issue cncf#96
  adds BDD coverage

Signed-off-by: Robert Kielty <robert.kielty@cncf.io>
  - moves the shared project route client into /projects/[id]/layout.tsx so
    navigation between project sections no longer remounts the entire project
    shell or refetches shared project state.

  - derives the active reconciliation section from the selected layout segment
    and keep the individual route pages as thin route markers.

Signed-off-by: Robert Kielty <robert.kielty@cncf.io>
@RobertKielty RobertKielty self-assigned this Mar 16, 2026
@RobertKielty RobertKielty changed the title Roll call selection bug Roll call maintainer selection bug Mar 16, 2026
@RobertKielty RobertKielty changed the title Roll call maintainer selection bug Roll call maintainer selection bugfix Mar 16, 2026
@RobertKielty RobertKielty merged commit bfa445e into cncf:main Mar 16, 2026
9 checks passed
@RobertKielty RobertKielty deleted the roll-call-selection-bug branch March 16, 2026 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: MAINTAINER ROLL CALL maintainer selection checkboxes not selectable

1 participant