Fix/enhance sqs partial acknowledgement handling#1
Open
co2plant wants to merge 13 commits into
Open
Conversation
- Changed null to DeleteMessageBatchResponse
DeleteMessageBatch response - Correlate items using message IDs for accurate mapping - Pass different lists to the SqsAcknowledgementException constructor to handle partial failures
- Extract partial error handling logic from the deleteMessages method - Improved code readability and maintainability - placed the calling method at the top and the helper method at the bottom
…m SqsAcknowledgementExecutor.
- handle DeleteMessageBatch partial failures in a dedicated method - map AWS failed entry IDs to original message IDs - populate SqsAcknowledgementException with successful/failed message lists - avoid wrapping SqsAcknowledgementException twice - extend SqsAcknowledgementExecutorTests to assert partial failure mapping
- fix callback interface name to AsyncAcknowledgementResultCallback - explain that onFailure receives SqsAcknowledgementException on partial failures - add an example using successful/failed acknowledgement message lists for retry
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
💡 Motivation and Context
💚 How did you test it?
📝 Checklist
🔮 Next steps