fix: dev-tagged subarr-subgen builds don't nag a backward update#233
Merged
Conversation
A local/soak image bakes a dev-<sha> release tag (scripts/build.sh) that cannot be ranked against date-style release tags, so the #224 comparison reported a difference and pointed the user BACKWARD to the latest release. Treat a dev/missing tag as unknown (None) — same bucket as #224: show the latest release, never claim an update. Extracted to a tested _subgen_update_version helper. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Your soak box (and any locally-built subarr-subgen) bakes a
dev-<sha>release tag via scripts/build.sh. The #224 update comparison rankeddev-5db497bagainst the latest releasev2026.05.3-r8, found them different, and reported "update available" — pointing BACKWARD to r8 even though the dev build is the newer r9 candidate.Fix: a
dev-(or missing) tag is an unreleased, uncomparable version → resolve to None, the same "unknown current → show latest, never claim an update" bucket #224 established. Extracted to a_subgen_update_versionhelper with tests.Released images (r9+) carry proper
v2026.05.3-rNtags and compare correctly — unaffected. Verified live on :9923: the subarr-subgen update badge cleared (has_update False).