refactor: extract daemon path helpers to avoid CLI importing cocoindex#130
Merged
refactor: extract daemon path helpers to avoid CLI importing cocoindex#130
Conversation
Move daemon_dir, daemon_socket_path, daemon_pid_path, daemon_log_path, and connection_family from daemon.py into a new lightweight _daemon_paths.py module. This prevents the CLI client from transitively importing cocoindex and its heavy dependencies (numpy, torch, etc.) when it only needs path utilities. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
tokenizers lacks pre-built wheels for cp314t (free-threaded ABI), so uv falls back to compiling from Rust source. This source build is fragile across macOS runner image updates and broke after the 20260406 image bump. Mark 3.14t jobs as continue-on-error since free-threaded wheel coverage across the ecosystem is still limited. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
daemon_dir,daemon_socket_path,daemon_pid_path,daemon_log_path,connection_family) fromdaemon.pyinto a new lightweight_daemon_paths.pymoduleclient.py,cli.py, and tests to import from_daemon_pathsinstead ofdaemoncocoindexand its heavy dependencies (numpy, torch, etc.) when it only needs path utilitiesTest plan