Add auto bindings for public members#184
Merged
pandamicro merged 2 commits intococos2d:v3from Jul 30, 2015
Merged
Conversation
Contributor
Author
|
Task for cocos2d/cocos2d-x#9958 |
pandamicro
added a commit
that referenced
this pull request
Jul 30, 2015
Add auto bindings for public members
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original idea and implementation from #139 of @samuele3hu
Based on his implementation, I added
fieldto ini configuration to permit adding fields that need to be bound. By default no public field is bound to ensure compatibility with the current cocos2d code base, because there are already some public fields bound manually. In the future, they should be totally replaced by auto bindings, andfieldshould be removed from the configuration.@dualface I have added the original implementation of @samuele3hu for Lua bindings.
You can improve it and in the future, auto binding should be able to bind lua public members.
Thank you @samuele3hu !