Skip to content

PR 6819ed8fa96425c712269585ee9ddad8#159

Open
codacydemo wants to merge 1 commit into
masterfrom
6819ed8fa96425c712269585ee9ddad8
Open

PR 6819ed8fa96425c712269585ee9ddad8#159
codacydemo wants to merge 1 commit into
masterfrom
6819ed8fa96425c712269585ee9ddad8

Conversation

@codacydemo
Copy link
Copy Markdown
Owner

@codacydemo codacydemo commented Aug 8, 2019

No description provided.

@codacydemo
Copy link
Copy Markdown
Owner Author

codacydemo commented Aug 8, 2019

Codacy Here is an overview of what got changed by this pull request:

Issues
======
- Added 11
           

Complexity increasing per file
==============================
- py_unittest_20192208012245.py  1
- py_error_20192208012245.py  4
- py_xss_20192208012245.py  1
         

Clones added
============
- py_error_20192208012245.py  1
- py_xss_20192208012245.py  1

See the complete overview on Codacy

codacydemo
codacydemo commented Aug 8, 2019
View reviewed changes
Comment thread static/js/js_error_20192208012245.js

function world() {
password a = "dummy"
let b = "line"
Copy link
Copy Markdown
Owner Author

@codacydemo codacydemo Aug 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codacy Issue found: 'b' is defined but never used.

codacydemo
codacydemo commented Aug 8, 2019
View reviewed changes
Comment thread py_error_20192208012245.py

def calc(number,times):
program = 'a = 5\nb=10\nprint("Sum =", a+b)'
exec(program)
Copy link
Copy Markdown
Owner Author

@codacydemo codacydemo Aug 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codacy Issue found: Use of exec

codacydemo
codacydemo commented Aug 8, 2019
View reviewed changes
Comment thread py_error_20192208012245.py
@@ -0,0 +1,46 @@
import lxml
Copy link
Copy Markdown
Owner Author

@codacydemo codacydemo Aug 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codacy Issue found: Using lxml to parse untrusted XML data is known to be vulnerable to XML attacks. Replace lxml with the equivalent defusedxml package.

codacydemo
codacydemo commented Aug 8, 2019
View reviewed changes
Comment thread py_error_20192208012245.py
@@ -0,0 +1,46 @@
import lxml
Copy link
Copy Markdown
Owner Author

@codacydemo codacydemo Aug 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codacy Issue found: Unused import lxml

codacydemo
codacydemo commented Aug 8, 2019
View reviewed changes
Comment thread py_error_20192208012245.py
class C20192208012245():
"This is an example class"
a = 10
def func(self):
Copy link
Copy Markdown
Owner Author

@codacydemo codacydemo Aug 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codacy Issue found: Method could be a function

codacydemo
codacydemo commented Aug 8, 2019
View reviewed changes
Comment thread static/js/js_error_20192208012245.js
@@ -0,0 +1,10 @@
function hello() {
let a = "dummy"
Copy link
Copy Markdown
Owner Author

@codacydemo codacydemo Aug 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codacy Issue found: 'a' is defined but never used.

codacydemo
codacydemo commented Aug 8, 2019
View reviewed changes
Comment thread py_error_20192208012245.py
get_input = web.input()
param1 = get_input['param1'] if 'param1' in get_input else None
if (param1):
x = eval(param1)
Copy link
Copy Markdown
Owner Author

@codacydemo codacydemo Aug 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codacy Issue found: Unused variable 'x'

codacydemo
codacydemo commented Aug 8, 2019
View reviewed changes
Comment thread py_error_20192208012245.py
get_input = web.input()
param1 = get_input['param1'] if 'param1' in get_input else None
if (param1):
x = eval(param1)
Copy link
Copy Markdown
Owner Author

@codacydemo codacydemo Aug 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codacy Issue found: Use of possibly insecure function - consider using safer ast.literal_eval.

codacydemo
codacydemo commented Aug 8, 2019
View reviewed changes
Comment thread py_error_20192208012245.py

def calc(number,times):
program = 'a = 5\nb=10\nprint("Sum =", a+b)'
exec(program)
Copy link
Copy Markdown
Owner Author

@codacydemo codacydemo Aug 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codacy Issue found: Use of exec detected.

codacydemo
codacydemo commented Aug 8, 2019
View reviewed changes
Comment thread static/js/js_error_20192208012245.js
return "Hello";
}

function world() {
Copy link
Copy Markdown
Owner Author

@codacydemo codacydemo Aug 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codacy Issue found: 'world' is defined but never used.

codacydemo
codacydemo commented Aug 8, 2019
View reviewed changes
Comment thread static/js/js_error_20192208012245.js
@@ -0,0 +1,10 @@
function hello() {
Copy link
Copy Markdown
Owner Author

@codacydemo codacydemo Aug 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codacy Issue found: 'hello' is defined but never used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@codacydemo