Conversation
- AI translation for FR and TF locale
- horizontal repartition on large display - Footer component - improve translation
codastream
requested review from
Ilia1177,
jmtth,
lisambet and
rom98759
as code owners
There was a problem hiding this comment.
Pull request overview
Adds legal pages (Terms of Service + Privacy Policy) to the Nginx frontend, wires them into routing, and introduces a global footer entry point with localized content.
Changes:
- Add
/privacyand/tospages and register them in the app router. - Introduce a
Footercomponent and render it from the sharedPagelayout container. - Extend
Scrollablelayout/styling props and add localized legal text (EN/FR/TF).
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 11 comments.
Show a summary per file
| File | Description |
|---|---|
| srcs/nginx/src/pages/TosPage.tsx | New Terms of Service page using i18n strings. |
| srcs/nginx/src/pages/PrivacyPage.tsx | New Privacy Policy page with in-page anchors + i18n content. |
| srcs/nginx/src/pages/HomePage.tsx | Adjust Scrollable usage/layout for the home page. |
| srcs/nginx/src/locales/tf/common.json | Add TF locale legal content + shared legal metadata. |
| srcs/nginx/src/locales/fr/common.json | Add FR locale legal content + shared legal metadata. |
| srcs/nginx/src/locales/en/common.json | Add EN locale legal content + shared legal metadata. |
| srcs/nginx/src/components/organisms/PageContainer.tsx | Render footer in the shared Page layout. |
| srcs/nginx/src/components/molecules/Footer.tsx | New footer with links to legal pages. |
| srcs/nginx/src/components/atoms/Scrollable.tsx | Add styling hooks + change default layout/height behavior. |
| srcs/nginx/src/components/atoms/Circle.tsx | Adjust circle container sizing to match new layout. |
| srcs/nginx/src/App.tsx | Register /privacy and /tos routes. |
There was a problem hiding this comment.
Le footer ne devrait pas etre sur toute les pages ?
There was a problem hiding this comment.
remis ensemble sur Tournamenebt Menu
There was a problem hiding this comment.
Je pense que tu n'as pas mergé le main sur ta branche car il manque des fichiers comme CircleButtonSimple.tsx
et des fichiers ont été modifiés alors que cela n'apparaît pas ici ? TournamentPage utilise des CircleButtonSimple
Il y a peut-être d'autres fichiers ou modifications qui n'ont pas été pris en compte ?
- remove link on top of menu elements - display footer
- errors type in register form - localization
mobile:
higher resolution:
