You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Removed kitchen_wall_7 to place the popcorn table there
Pictures
New top level file
A new top level file was added which combines all macros. This creates a kitchen with the popcorn table and without the wall_7.
New parameter in IAI_kitchen_walls
For the purpose of creating a kitchen without the wall_7 a new parameter was added to the macro. This parameter, named "wall_7", is a boolean value that is set to true if the wall should be included and false if not.
@Tigul please add the board, where the pot spawns, and its symmetric counterpart, both under the drawers. Also, is it really necessary to delete the "wall7"? In the real lab the wall is there, is it maybe located at a different pose? In that case it's better to fix the pose of the wall instead of deleting it.
@Tigul I'll keep this PR open until Thomas is done with his demo, I guess. Then we can merge the complete version of the table and won't need any follow-up PRs.
@Tigul@tlipps the popcorn table shouldn't be per default added to the kitchen URDF. It should rather be optional. It definitely shouldn't be added to the kitchen URDF like this. So either there should be a new combined URDF, which pull in both the ktichen and the popcorn table, or on the CRAM side we should be able to handle multiple environment objects, like :kitchen and :popcorn-table at the same time. That would make the hard-coded :kitchen as the name of the environment a bit problematic in CRAM. But it would be the clean solution. So we should separate the two URDFs and load them separately under different ROS parameters, e.g., kitchen_description and popcorn_table_description.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
Pictures
New top level file
A new top level file was added which combines all macros. This creates a kitchen with the popcorn table and without the wall_7.
New parameter in IAI_kitchen_walls
For the purpose of creating a kitchen without the wall_7 a new parameter was added to the macro. This parameter, named "wall_7", is a boolean value that is set to true if the wall should be included and false if not.