Added and modified files for usage with openEASE#81
Open
sasjonge wants to merge 4 commits intocode-iai:masterfrom
Open
Added and modified files for usage with openEASE#81sasjonge wants to merge 4 commits intocode-iai:masterfrom
sasjonge wants to merge 4 commits intocode-iai:masterfrom
Conversation
Contributor
|
why are you adding iai_kitchen/urdf/iai_kitchen_python.urdf? this should always be generated from the xacro, to make sure its up to date. |
Author
|
Thats true, for openEASE we need a urdf file. I thought this repository could be the right place for it. |
Contributor
|
You should come up with a way to generate the urdf yourself. If we push the urdf here, the next one who changes the xacro will forget to update the urdf for sure. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added chair and table to kitchen.owl and added urdf used in openEASE. We use the obj files in the urdf file, and modified the empty material files so that the chair and table are simply brown.