Skip to content

fix: silence ClosedSendChannelException during bidi stream reconnect #1017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bmc08gt merged 1 commit into from
Jun 29, 2026
Merged

fix: silence ClosedSendChannelException during bidi stream reconnect #1017

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions services/opencode/src/main/kotlin/com/getcode/opencode/internal/bidi/OpenStream.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,15 +122,23 @@ fun <Request, Response, StreamRef> openBidirectionalStream(
requestChannel.send(initialRequest())
trace(tag = tag, message = "Initial request sent")
} catch (e: Exception) {
collectionJob.cancel()
requestChannel.close()
if (e is ClosedSendChannelException) {
// Expected race: the response flow can close the request
// channel (e.g. gRPC TRANSIENT_FAILURE) before the initial
// send completes. Retry silently.
trace(tag = tag, message = "Channel closed before initial request, retrying")
onReconnectAttempt?.invoke(attempt, e)
continue
}
trace(
tag = tag,
message = "Failed to send initial request",
type = TraceType.Error,
error = e
)
collectionJob.cancel()
requestChannel.close()
if (isRetryable(e) || e is ClosedSendChannelException) {
if (isRetryable(e)) {
onReconnectAttempt?.invoke(attempt, e)
continue
}
Expand Down
Loading