fix(chat): migrate legacy UserProfile phone/email on decode#1047
Merged
Conversation
Chat member profiles persisted before phone/email were modeled as VerifiableContactMethod stored verifiedPhoneNumber/verifiedEmailAddress as plain strings. After the migration those keys no longer matched, and since the new nullable fields had no defaults, kotlinx.serialization treated them as required and threw MissingFieldException on decode, crashing chat loads for upgrading users. Decode through a tolerant compat DTO that carries both the current and legacy keys, migrating a present legacy string to a verified VerifiableContactMethod. Add null defaults to the new fields and wrap the decode in runCatching as a backstop against future schema drift. Signed-off-by: Brandon McAnsh <git@bmcreations.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chat member profiles persisted before phone/email were modeled as VerifiableContactMethod stored verifiedPhoneNumber/verifiedEmailAddress as plain strings. After the migration those keys no longer matched, and since the new nullable fields had no defaults, kotlinx.serialization treated them as required and threw MissingFieldException on decode, crashing chat loads for upgrading users.
Decode through a tolerant compat DTO that carries both the current and legacy keys, migrating a present legacy string to a verified VerifiableContactMethod. Add null defaults to the new fields and wrap the decode in runCatching as a backstop against future schema drift.